Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-icons: Replace stroke value to "currentColor" #1226

Merged
merged 1 commit into from
Jun 4, 2024
Merged

plasma-icons: Replace stroke value to "currentColor" #1226

merged 1 commit into from
Jun 4, 2024

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Jun 3, 2024 •
edited
Loading

Stroke

  • заменили значение свойства stroke на currentColor

Before

Screenshot 2024-06-03 at 18 35 35

After

Screenshot 2024-06-03 at 18 33 57

What/why changed

Цвет для свойства stroke не наследовался, потому что значение были константой (захардкожены внутри самого svg). Теперь используем currentColor чтобы была возможность управлять цветом из вне.

codesandbox

https://codesandbox.io/p/sandbox/plasma-web-example-forked-6w8vvp?file=%2Fpackage.json%3A3%2C64

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@Yakutoc Yakutoc self-assigned this Jun 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1226/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1226/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1226/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1226/b2c-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1226/ui-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1226/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1226/sdds-serv-storybook/

@Yakutoc Yakutoc marked this pull request as ready for review June 3, 2024 11:51
@Yakutoc Yakutoc removed the request for review from Yeti-or June 3, 2024 11:51
@Yeti-or Yeti-or removed the request for review from shuga2704 June 4, 2024 06:59
@Yakutoc Yakutoc added this pull request to the merge queue Jun 4, 2024
@Yakutoc Yakutoc removed the request for review from TitanKuzmich June 4, 2024 07:20
Merged via the queue into dev with commit 76c4fe4 Jun 4, 2024
29 checks passed
@Yakutoc Yakutoc deleted the icons-fill-stroke-property branch June 4, 2024 07:30
@Salute-Eva Salute-Eva mentioned this pull request Jun 11, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neretin-trike neretin-trike neretin-trike approved these changes

@Yeti-or Yeti-or Yeti-or approved these changes

Assignees

@Yakutoc Yakutoc

Labels
plasma-icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yakutoc @Yeti-or @neretin-trike